Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
reweeden
force-pushed
the
rew/pr-3242-refactor-edl-client
branch
3 times, most recently
from
7b41a12 to
9b6ebb2
Compare
reweeden
force-pushed
the
rew/pr-3242-refactor-edl-client
branch
2 times, most recently
from
fb2e5e6 to
82d4657
Compare
reweeden
force-pushed
the
rew/pr-3242-refactor-edl-client
branch
from
82d4657 to
bc42fec
Compare
gjclark
previously approved these changes
Jan 2, 2025
mattp0
reviewed
Jan 3, 2025
| # sample json in this case: | ||
| # `{"status_code": 403, "error_description": "EULA Acceptance Failure", | ||
| # "resolution_url": "http://uat.urs.earthdata.nasa.gov/approve_app?client_id=LqWhtVpLmwaD4VqHeoN7ww"}` | ||
| log.warning('user needs to sign the EULA') |
Contributor
There was a problem hiding this comment.
is it bad to log the user name here? It would make searching the logs far easier in something like tea?
Contributor
Author
There was a problem hiding this comment.
In the TEA code the username is added to the log context meaning it will automatically show up when JSON logging is used.
I don't actually know how to get the username here in general. I think it would have to come from the request params somehow, but might not be entirely consistent.
Contributor
Author
There was a problem hiding this comment.
It wouldn't be bad though.
mattp0
reviewed
Jan 3, 2025
mattp0
previously approved these changes
Jan 3, 2025
reweeden
force-pushed
the
rew/pr-3242-refactor-edl-client
branch
from
bc42fec to
7898c91
Compare
gjclark
approved these changes
Jan 6, 2025
mckadesorensen
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor urllib request calls to EDL to an EDL client so that each request is handled consistently with regards to the timing code, log calls and error handling.
I tested this by deploying a dev stack of TEA and running a few checks with bearer tokens and browser downloads. asfadmin/thin-egress-app#855